WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Assert that the p2m lock is held in ept_sync_domain

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Assert that the p2m lock is held in ept_sync_domain
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2009 13:44:54 +0100
Cc: Xiaohui Xin <Xiaohui.xin@xxxxxxxxx>, Xin Li <xin.b.li@xxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 22 Sep 2009 05:45:54 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=FOVrF1nO3FPDcYJ8xjI5FN/WoswBzizuMY8HD3Dsd14=; b=yBEUc2WyZGJngmRxiYhF9MSSohUj2+q74YJULhPhLbW+NC6ecBW+xyEzYj4uttySdT Du03KX+VB/baIhd5teMtR7/N/GtClOtRkz4p3/MpXk1tWECaolRwAryCY9fODkqzextb XO0dt4AAGkK3WQteILE80MtpFK07/P7QuZBEQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=VzBLA63JjHM3qyb09uaTvYISHFAszsxQax8I2GDGNfAb9NsS/5WYfBGWJLLvDsPLyH a4ITCFStTutFSTJ82J8ymH6ihv6x5PXn8FgymkWgV+5K1zW3hHgkajP+YzS9Uh+4c+yG 8PEtv9VSKDxaZ9WCCdM0+36A14uP0R0M6bBIg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

On Tue, Sep 22, 2009 at 10:17 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 22/09/2009 10:02, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>
>>> Please see what you think of xen-unstable:20244.
>>
>> With no assertion in ept_sync_domain() on any locks held, is it guaranteed
>> that the function cannot be entered twice at the same time for a given
>> guest? If not, passing a pointer to the new ept_synced member isn't any
>> better than passing the one to domain_dirty_cpumask.
>
> I assume George is knowledgeable on that area. If calls to ept_sync_domain()
> are not serialised then I think synchronisation around the
> ept_needs_flush/ept_synced cpumask is indeed pretty suspect. If there isn't
> such a serialising lock, we could add one to ept_sync_domain() quite safely.
>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

Attachment: assert-p2m-locked-in-ept-sync-domain.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Assert that the p2m lock is held in ept_sync_domain, George Dunlap <=