WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [patch] qemu-xen: pxe: Don't look for PXE ROMs when running

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [patch] qemu-xen: pxe: Don't look for PXE ROMs when running as a DM
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 18 Sep 2009 15:20:11 +1000
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Sep 2009 22:20:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
Searching for PXE ROMs in attached NICs is unnecessary as the ROM
that is used is included in the hvmloader binary. In the case where
there are only pass-through NICs it will cause the boot to fail
as the NICs are not known to qemu-xen at the time that this check is made.
In other words, without this change PXE boot from a pass-through
device will fail.

This has likely been broken since I changed around the pass-through
code so that devices passed-through at boot-time are handled by hot-plug.

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: ioemu-remote/vl.c
===================================================================
--- ioemu-remote.orig/vl.c      2009-09-18 12:15:39.000000000 +1000
+++ ioemu-remote/vl.c   2009-09-18 12:18:14.000000000 +1000
@@ -5627,6 +5627,7 @@ int main(int argc, char **argv, char **e
     }
     net_client_check();
 
+#ifndef CONFIG_DM
 #ifdef TARGET_I386
     /* XXX: this should be moved in the PC machine instantiation code */
     if (net_boot != 0) {
@@ -5655,6 +5656,7 @@ int main(int argc, char **argv, char **e
        }
     }
 #endif
+#endif
 
     /* init the bluetooth world */
     for (i = 0; i < nb_bt_opts; i++)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [patch] qemu-xen: pxe: Don't look for PXE ROMs when running as a DM, Simon Horman <=