WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Error restoring DomU when using GPLPV

To: "mukesh.rathor@xxxxxxxxxx" <mukesh.rathor@xxxxxxxxxx>, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Subject: Re: [Xen-devel] Error restoring DomU when using GPLPV
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 17 Sep 2009 07:21:00 +0100
Cc: Joshua West <jwest@xxxxxxxxxxxx>, James Harper <james.harper@xxxxxxxxxxxxxxxx>, "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, "annie.li@xxxxxxxxxx" <annie.li@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "wayne.gong@xxxxxxxxxx" <wayne.gong@xxxxxxxxxx>
Delivery-date: Wed, 16 Sep 2009 23:21:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AB14F8E.2050804@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aco3D2fVKjY59yN0QhOwXRZ79RyPwQAT55v6
Thread-topic: [Xen-devel] Error restoring DomU when using GPLPV
User-agent: Microsoft-Entourage/12.20.0.090605
Yeah, all the PV drivers are having to do is balloon down one page for every
Xenheap page they map. There's no further complexity than that, so let's not
make a mountain out of a molehill. The approach as discussed and now
implemented should work fine with tmem I think.

 -- Keir

On 16/09/2009 21:50, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:

> just in case someone missed the thread earlier,
> 
> 3 = 1 shinfo + 2 gnt frames default.
> 
> so, tot_pages + shinfo + num gnt frames.
> 
> 
> Mukesh
> 
> 
> 
> Dan Magenheimer wrote:
>> Before we close down this thread, I have a concern:
>> 
>> According to Mukesh, the fix to this bug is dependent
>> on the pv drivers tracking tot_pages for a domain
>> and ballooning to ensure tot_pages+3 does not exceed
>> max_pages for the domain.
>> 
>> Well, tmem can affect tot_pages for a domain inside
>> the hypervisor without any notification to pv drivers
>> or the balloon driver.  And I'd imagine that PoD and
>> future memory optimization mechanisms such as
>> swapping and page-sharing may do the same.
>> 
>> So this solution seems very fragile.
>> 
>> Dan
>> 
>>> -----Original Message-----
>>> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>>> Sent: Wednesday, September 16, 2009 6:28 AM
>>> To: Annie Li
>>> Cc: Joshua West; Dan Magenheimer; xen-devel; Kurt Hackel;
>>> James Harper;
>>> Wayne Gong
>>> Subject: Re: [Xen-devel] Error restoring DomU when using GPLPV
>>> 
>>> 
>>> On 16/09/2009 12:10, "ANNIE LI" <annie.li@xxxxxxxxxx> wrote:
>>> 
>>>>> I will do more test to make sure it and update here.
>>>> I tried to map 256 grant frames during initialization and
>>> balloon down
>>>> 256+1(shinfo+gnttab) pages driver first
>>>> load. Then i did save/restore for 50 times, and live
>>> migration for 10
>>>> times. No error occurs.
>>> Okay, well I still can't explain why that fixes it, but
>>> clearly it does. So
>>> that's good. :-)
>>> 
>>>  -- Keir
>>> 
>>> 
>>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel