 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is
| To: | Sheng Yang <sheng@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler |
| From: | Cyrill Gorcunov <gorcunov@xxxxxxxxx> |
| Date: | Wed, 16 Sep 2009 12:58:35 +0400 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Eddie Dong <eddie.dong@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx> |
| Delivery-date: | Wed, 16 Sep 2009 02:03:07 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=4FVIpbwxQSIPSzUHf5RITTgKBBQKIKABHnX+MNygKI0=; b=U4Iq1s/k06zZ3G6Dj+rC9Xz7x39tYyve079XDS7b1RLBv4jNloy4suJJZqmeKjnay8 eX0w+sL+ttLEhFl64Lwl5+evkk51z8ByoSbR48Vr9HlfsqNbhTT9jZG4o+ckIR8KM2jX VB6mPlH4pS2SqvUbRc11EgvPAElOsE+5bB/M0= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=YoYaZ0D7KNIN0tVWAJZS+096pRdbuOYvi1fgFphJtxjz/nJTwlpkc9WG1WYQ8GG4Mt ozQr2B+KB/l9OTqm4dWCxqwv7um1BTCmZZrfET3K7yJHTRXdahmsIcUp4aola4rRpvOg lL54F8DtHxd7rePNhxcRCPNXeZ6giEAzOFkDw= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1253090551-7969-9-git-send-email-sheng@xxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <1253090551-7969-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1253090551-7969-9-git-send-email-sheng@xxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
[Sheng Yang - Wed, Sep 16, 2009 at 04:42:29PM +0800]
| Xen hybrid guest don't use lapic, but smp_generic_interrupt() assume all it's
| caller using lapic.
|
| Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
| ---
| arch/x86/kernel/irq.c | 3 ++-
| 1 files changed, 2 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
| index c3fe010..a887d25 100644
| --- a/arch/x86/kernel/irq.c
| +++ b/arch/x86/kernel/irq.c
| @@ -236,7 +236,8 @@ void smp_generic_interrupt(struct pt_regs *regs)
| {
| struct pt_regs *old_regs = set_irq_regs(regs);
|
| - ack_APIC_irq();
| + if (!disable_apic)
| + ack_APIC_irq();
|
| exit_idle();
Hi Sheng,
is there was some problem with it? I'm asking you
because if disable_apic=1 then any apic write/read
operations become NOPs. So I don't see how it may
hurt. But I could be missing something.
-- Cyrill
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | RE: [Xen-devel] [PATCH 1/2] graphics passthrough with VT-d, Han, Weidong |
|---|---|
| Next by Date: | [Xen-devel] Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler, Cyrill Gorcunov |
| Previous by Thread: | [Xen-devel] [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler, Sheng Yang |
| Next by Thread: | [Xen-devel] Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler, Cyrill Gorcunov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
