RE: [Xen-devel] [PATCH 2/2 v2] graphics passthrough with VT-d

["Han, Weidong" <weidong.han@xxxxxxxxx>]

Ian,

Did you have a look at this patch? What's your opinion on it? Thanks.


Regards,
Weidong

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Han, Weidong
Sent: 2009年9月6日 13:25
To: 'Ian Jackson'
Cc: 'xen-devel@xxxxxxxxxxxxxxxxxxx'; Lin, Ben Y; Kay, Allen M; 'Jean Guyader'; 
'Keir.Fraser@xxxxxxxxxxxxx'; 'bengheng@xxxxxxxxxxxxxx'
Subject: RE: [Xen-devel] [PATCH 2/2 v2] graphics passthrough with VT-d

Ian Jackson wrote:
> Han, Weidong writes ("[Xen-devel] [PATCH 2/2 v2] graphics passthrough
> with VT-d"): 
>> This patch supports basic gfx passthrough on QEMU:
>>   - disable emulated VGA adpater if there is passthroughed gfx
>>   - retrieve VGA bios from host 0xC0000, then load it to guest
>> 0xC0000 
>>   - register/unregister legacy VGA I/O ports and MMIOs for
>> passthroughed gfx 
> 
> Thanks for this.  However:
> 
>  * It breaks the build if passthrough is disabled (eg due to lack
>    of pciutils-dev).

It won't break the build when lack of pciutils-dev for me.

> 
>  * Reindenting all of the code in pc.c which initalises out the
>    various graphics cards is very merge-unfriendly.  Is that change
>    needed at all, or could you just disable the various graphics cards
>    on the qemu command line ?
> 
>  * Likewise, in vl.c.

Ok. I updated the code to add a new vga type for gfx passthrough. Then it 
needn't to add the check before various vga initialization in pc.c and vl.c. 
Attached the updated patch. Pls review it. Thanks.

Regards,
Weidong

> 
> Regards,
> Ian.

qemu-gfx-passthrough-v3.patch
Description: qemu-gfx-passthrough-v3.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel