WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: add an extra check when validating a huge p

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: add an extra check when validating a huge pv L2 entry
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 09 Sep 2009 16:35:53 +0100
Cc:
Delivery-date: Wed, 09 Sep 2009 08:36:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AA7E3A90200007800014295@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoxYQuWxKAPUsRUSciechUkScgxgwAAiuNt
Thread-topic: [Xen-devel] [PATCH] x86: add an extra check when validating a huge pv L2 entry
User-agent: Microsoft-Entourage/12.19.0.090515
On 09/09/2009 16:19, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> -            rc = get_data_page(mfn_to_page(m), d, writeable);
> +            if ( mfn_valid(m) )
> +                rc = get_data_page(mfn_to_page(m), d, writeable);
> +            else
> +                rc = -EINVAL;

'else rc = 0' would be more like it, eh?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel