WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] drbd patch breaks pygrub booting

To: Michael Renner <michael.renner@xxxxxxxxxxx>
Subject: [Xen-devel] drbd patch breaks pygrub booting
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 9 Sep 2009 12:04:22 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 09 Sep 2009 04:04:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Changeset 20158:f9ce5858 introduces some new code around line 3002 in
XendDomainInfo.py which refers to a variable `disktype' which is not
set at all.

As a consequence, no pygrub-based domain will boot any more.  An
example stacktrace from xend.log is below.  I think, but I'm not sure,
that `disktype' here should read `devtype'.

Ian.

[2009-09-09 10:47:35 4579] ERROR (xmlrpclib2:178) Internal error handling 
xend.domain.create
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/xen/util/xmlrpclib2.py", line 131, in 
_marshaled_dispatch
    response = self._dispatch(method, params)
  File "/usr/lib/python2.4/SimpleXMLRPCServer.py", line 406, in _dispatch
    return func(*params)
  File "/usr/lib/python2.4/site-packages/xen/xend/server/XMLRPCServer.py", line 
79, in domain_create
    info = XendDomain.instance().domain_create(config)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line 970, in 
domain_create
    dominfo = XendDomainInfo.create(config)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 102, 
in create
    vm.start()
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 453, 
in start
    XendTask.log_progress(31, 60, self._initDomain)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendTask.py", line 209, in 
log_progress
    retval = func(*args, **kwds)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 
2599, in _initDomain
    self._configureBootloader()
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 
3002, in _configureBootloader
    if disktype.find(":") != -1:
UnboundLocalError: local variable 'disktype' referenced before assignment

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>