WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH][PV_OPS_DOM0]Fix the host S3 resume hang

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH][PV_OPS_DOM0]Fix the host S3 resume hang
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Thu, 3 Sep 2009 18:31:31 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 03 Sep 2009 03:33:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A9FB1910200007800013284@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <8FED46E8A9CA574792FC7AACAC38FE77028739D44F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A9FB1910200007800013284@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcosfmdD+D9hmyZCS/a35Dsvvt9/aQAAuczg
Thread-topic: [Xen-devel] [PATCH][PV_OPS_DOM0]Fix the host S3 resume hang
Jan Beulich wrote:
> Instead of doing the check twice in the suspend and resume
> handlers, why
> don't you just suppress registration of the sysdev(s) in
> ioapic_init_sysfs()? 

Good idea. Here is it.

Fix the host S3 resume hang

Current pv-ops dom0 is doing ioapic suspend/resume while doing host S3. The
ioapic resume will cause a guest_write_ioapic error and hang the S3 resume
process. It is actually not necessary for dom0 to do ioapic suspend/resume
because hypervisor already cover this.

Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 18d957e..77151ce 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3162,6 +3162,9 @@ static int __init ioapic_init_sysfs(void)
        struct sys_device * dev;
        int i, size, error;
 
+       if (xen_initial_domain())
+               return 0;
+
        error = sysdev_class_register(&ioapic_sysdev_class);
        if (error)
                return error;

Attachment: no-ioapic-resume.patch
Description: no-ioapic-resume.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>