| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: a room for blkio-cgroup in struct page_cgroup
|
To: |
"Ryo Tsuruta" <ryov@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: a room for blkio-cgroup in struct page_cgroup |
|
From: |
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@xxxxxxxxxxxxxx> |
|
Date: |
Wed, 2 Sep 2009 22:12:51 +0900 (JST) |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, containers@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, balbir@xxxxxxxxxxxxxxxxxx |
|
Delivery-date: |
Wed, 02 Sep 2009 06:16:02 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
Importance: |
Normal |
|
In-reply-to: |
<20090902.205137.71100180.ryov@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20090902.205137.71100180.ryov@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
SquirrelMail/1.4.16 |
Ryo Tsuruta wrote:
> Hi Kamezawa-san,
>
> As you wrote before (http://lkml.org/lkml/2009/7/22/65)
>> To be honest, what I expected in these days for people of blockio
>> cgroup is like following for getting room for themselves.
> <<snip>>
>> --- mmotm-2.6.31-Jul16.orig/include/linux/page_cgroup.h
>> +++ mmotm-2.6.31-Jul16/include/linux/page_cgroup.h
>> @@ -13,7 +13,7 @@
>> struct page_cgroup {
>> unsigned long flags;
>> struct mem_cgroup *mem_cgroup;
>> - struct page *page;
>> + /* block io tracking will use extra unsigned long bytes */
>> struct list_head lru; /* per cgroup LRU list */
>> };
>
> Have you already added a room for blkio_cgroup in struct page_cgroup?
No.
> If not, I would like you to apply the above change to mmotm.
>
Plz wait until October. We're deadly busy and some amount of more important
patches are piled up in front of us. I have no objections if you add
a pointer or id because I know I can reduce 8(4)bytes later.
Just add (a small) member for a while and ignore page_cgroup's size.
I'll fix later.
> The latest blkio-cgroup has reflected the comments you pointed out.
> I would also like you to give me any comments on it and consider
> merging blkio-cgroup to mmotm.
>
BTW, do you all have cosensus about implementation ?
Bye,
-Kame
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home