WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] default the videoram to 4MB when it is not set

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] default the videoram to 4MB when it is not set
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 28 Jul 2009 14:10:13 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jul 2009 06:09:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090728130624.GE5404@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.0907281358280.7532@kaball-desktop> <20090728130624.GE5404@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 28 Jul 2009, Samuel Thibault wrote:
> Stefano Stabellini, le Tue 28 Jul 2009 14:01:41 +0100, a écrit :
> > +    /* if vga_ram_size is not set and a videocard is required, default it 
> > to 4 MB */
> > +    } else if ( !vga_ram_size && (std_vga_enabled || vmsvga_enabled) ) {
> > +       fprintf(stderr,"Defaulting vram to 8MB\n");
> 
> typo here :)
> 
> > +       vga_ram_size = 4 * 1024 * 1024;
> 

Ooops, thanks for catching it :)

this is the fixed version:

---

diff --git a/vl.c b/vl.c
index 8ad9c9e..62bed05 100644
--- a/vl.c
+++ b/vl.c
@@ -5667,6 +5667,10 @@ int main(int argc, char **argv, char **envp)
     {
        fprintf(stderr,"-videoram option does not work with cirrus vga device 
model. Videoram set to 4M.\n");
        vga_ram_size = 4 * 1024 * 1024;
+    /* if vga_ram_size is not set and a videocard is required, default it to 4 
MB */
+    } else if ( !vga_ram_size && (std_vga_enabled || vmsvga_enabled) ) {
+       fprintf(stderr,"Defaulting vram to 4MB\n");
+       vga_ram_size = 4 * 1024 * 1024;
     }
 
     phys_ram_size = (machine->ram_require + vga_ram_size) & ~RAMSIZE_FIXED;
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>