WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI de

from [Simon Horman] [Permanent Link][Original]
To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 28 Jul 2009 18:56:46 +1000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jul 2009 01:57:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457501CB84C3F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200905300930.n4U9UOTG008828@xxxxxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501C9D9804E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090612063335.GF20581@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501C9D98091@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090615015311.GC5586@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501CB84C305@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090728071537.GA18448@xxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501CB84C3F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17) 
On Tue, Jul 28, 2009 at 04:42:17PM +0800, Cui, Dexuan wrote:
> Duplicate calls to setupOneDevice() in the case of HVM  are really odd to me. 

Personally I'd rather call the code twice than have extra if logic.
But your patch is ok with me.

> BTW, actually I suspect setupOneDevice() is unnecessary for HVM guest
> since looks all of the actual work of setupOneDevice() is done by
> ioemu-dm.

I suspect you are right there.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time, Cui, Dexuan
Next by Date:  RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time, Cui, Dexuan
Previous by Thread:  RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time, Cui, Dexuan
Next by Thread:  RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable] xend: hot-plug PCI devices at boot-time, Cui, Dexuan
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy