WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] cs 19927 crashes during boot with debug=y

To: Jan Beulich <JBeulich@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] cs 19927 crashes during boot with debug=y
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 15 Jul 2009 08:31:59 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Jul 2009 00:32:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A5DA0DC020000780000A7E3@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoFHaN9dnclDlaETSKsRRKpk43anQAALLkJ
Thread-topic: [Xen-devel] cs 19927 crashes during boot with debug=y
User-agent: Microsoft-Entourage/12.19.0.090515
On 15/07/2009 08:26, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Just by looking at the code I spotted one place that needs fixing:
> 
> for (cpu = 0; cpu < NR_CPUS; cpu++) {
> cpus_clear(per_cpu(cpu_sibling_map, cpu));
> cpus_clear(per_cpu(cpu_core_map, cpu));
> }
> 
> which clearly needs to be using for_each_possible_cpu(). (Huh, this is still
> named for_each_cpu() - Keir, shouldn't we get this in sync with the Linux
> naming?)

Feel free to submit patches for both issues. I too prefer the new Linux
name.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel