Re: [Xen-devel] [PATCH]Fix vlapic.h type

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 10:31 +0100 on 08 Jul (1247049063), Patrick Colp wrote:
> Neil Turton wrote:
> > Patrick Colp wrote:
> >> Good catch. This line:
> >>
> >>   #define vlapic_vcpu(vpic)   (container_of((vpic), struct vcpu, \
> >>                                             arch.hvm_vcpu.vlapic))
> >>
> >> should probably also be changed to this:
> >>
> >>   #define vlapic_vcpu(vlapic)   (container_of((vlapic), struct vcpu, \
> >>                                               arch.hvm_vcpu.vlapic))
> > 
> > I'm not sure.  Do you intend to change the member name after hvm_vcpu
> > based on the macro parameter?
> 
> No. Why would I do that?
> 
> The issue here is that the macro parameter is referring to a vlapic and not a 
> vpic (which is something different). So for the sake of clarity, it should be 
> changed to vlapic instead of vpic.

but vlapic_vcpu(oops) would expand to  
 (container_of((oops), struct vcpu, arch.hvm_vcpu.oops)
                                                  ^^^^

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel