| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] RE: [RFC PATCH 1/4] (Take 2): tmem: Core API between kernel
|
To: |
Rik van Riel <riel@xxxxxxxxxx> |
|
Subject: |
[Xen-devel] RE: [RFC PATCH 1/4] (Take 2): tmem: Core API between kernel and tmem |
|
From: |
Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> |
|
Date: |
Tue, 7 Jul 2009 13:07:44 -0700 (PDT) |
|
Cc: |
npiggin@xxxxxxx, akpm@xxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, tmem-devel@xxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, dave.mccracken@xxxxxxxxxx, linux-mm@xxxxxxxxx, Rusty, sunil.mushran@xxxxxxxxxx, Avi Kivity <avi@xxxxxxxxxx>, Schwidefsky <schwidefsky@xxxxxxxxxx>, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, alan@xxxxxxxxxxxxxxxxxxx, chris.mason@xxxxxxxxxx |
|
Delivery-date: |
Tue, 07 Jul 2009 13:09:00 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4A538A34.7060101@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
> From: Rik van Riel [mailto:riel@xxxxxxxxxx]
> Subject: Re: [RFC PATCH 1/4] (Take 2): tmem: Core API between
>
> Dan Magenheimer wrote:
> > Tmem [PATCH 1/4] (Take 2): Core API between kernel and tmem
>
> I like the cleanup of your patch series.
Thanks much, but credit goes to Jeremy for suggesting this
very clean tmem_ops interface.
> However, what remains is a fair bit of code.
Yes, though much of the LOC is for clean layering and
readability. (Nearly half of the patch is now comments.)
> It would be good to have performance numbers before
> deciding whether or not to merge all this code.
On one benchmark that I will be presenting at Linux Symposium
(8 dual-VCPU guests with 384MB of initial memory and doing
self-ballooning to constrain memory, each guest compiling
Linux continually; quad-core-dual-thread Nehalem processor
with 4GB physical RAM) I am seeing savings of ~300 IO/sec
at an approximate cost of 0.1%-0.2% of one CPU. But
I admit much more benchmarking needs to be done.
Thanks,
Dan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home