xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] tools: portability fixes

from [Christoph Egger]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] tools: portability fixes
From:	Christoph Egger <Christoph.Egger@xxxxxxx>
Date:	Thu, 2 Jul 2009 12:03:03 +0200
Cc:	guanqun.lu@xxxxxxxxx
Delivery-date:	Thu, 02 Jul 2009 03:04:13 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	KMail/1.9.7

Hi!

Attached patch makes gtraceview compile on NetBSD.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

@Guanqun.Lu:
1. Why do you hardcode -lncurses, when there is a CURSES_LIBS variable ?
    The existence of it should have ring an alarm bell that your code isn't
    portable, i.e. that you can't blindly include <ncurses.h>.
2. The string operations look dangerous in respect to security. Please fix 
them.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

xen_gtrace.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] tools: portability fixes, Christoph Egger <= [Xen-devel] RE: [PATCH] tools: portability fixes, Lu, Guanqun

Previous by Date:	[Xen-devel] closed each side of the socket when cross migration, James Song
Next by Date:	[Xen-devel] [PATCH] ioemu: portability fixes for qemu-ifup, Christoph Egger
Previous by Thread:	[Xen-devel] closed each side of the socket when cross migration, James Song
Next by Thread:	[Xen-devel] RE: [PATCH] tools: portability fixes, Lu, Guanqun
Indexes:	[Date] [Thread] [Top] [All Lists]