WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Wed, 1 Jul 2009 15:01:04 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 01 Jul 2009 00:02:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A4B2185020000780000860D@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098402CB91D657@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A2FA418020000780000529A@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CB91DA07@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A3610D002000078000059E6@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CB978B8A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A361E570200007800005A38@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CB978C25@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A4A517E020000780000840C@xxxxxxxxxxxxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098402CD020900@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A4B2185020000780000860D@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn6FylGX2tv4FPOQJ+UqxiL+/zkQwAAT9Tg
Thread-topic: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0
Jan Beulich wrote:
>>>> "Ke, Liping" <liping.ke@xxxxxxxxx> 01.07.09 03:42 >>>
>> Jan Beulich wrote:
>>> Actually, there are still two issues with this:
>>> 
>>> First, shouldn't bind_virq_for_mce() and the associated message
>>> printing really only happen on Dom0 (i.e. be guarded by
>>> is_initial_xendomain()),
>>> just like the name suggests?
>> 
>> Yes. DOM0 is the only one who's responsible for MCE logging (Even
>> the error address belongs to other Guest). Currently mce_dom0.o is
>> only compiled when it is a privileged guest [depends on
>> (!XEN_UNPRIVILEGED_GUEST) according to Kconfig]. bind_virq_for_mce()
>> is also protected by the same thing [#if
>> defined(CONFIG_X86_XEN_MCE)] You mean we still need other guard? 
> 
> !XEN_UNPRIVILEGED_GUEST doesn't mean the kernel can't run as DomU,
> it's only the other way around. Hence a build-time check only isn't
> sufficient. 
> 

Ok, I will send out a patch adding guard before calling bind_virq_for_mce.

>>> 
>>> Second, I'm now seeing
>>> 
>>> (XEN) traps.c:2263:d0 Domain attempted WRMSR 000000000000017b from
>>> 00000000:0000003f to ffffffff:ffffffff. (XEN) traps.c:2263:d0 Domain
>>> attempted WRMSR 0000000000000400 from 00000000:000000ff to
>>> ffffffff:ffffffff. (XEN) traps.c:2263:d0 Domain attempted WRMSR
>>> 0000000000000404 from 00000000:ffffffff to ffffffff:ffffffff. (XEN)
>>> traps.c:2263:d0 Domain attempted WRMSR 0000000000000408 from
>>> 00000000:00000fff to ffffffff:ffffffff. (XEN) traps.c:2263:d0 Domain
>>> attempted WRMSR 000000000000040c from 00000000:00000003 to
>>> ffffffff:ffffffff. (XEN) traps.c:2263:d0 Domain attempted WRMSR
>>> 0000000000000410 from 00000000:3fffffff to ffffffff:ffffffff. (XEN)
>>> traps.c:2263:d0 Domain attempted WRMSR 0000000000000414 from
>>> 00000000:00000001 to ffffffff:ffffffff.
>>> 
>>> which isn't really nice.
>> 
>> I looked into the code, current CONFIG_X86_MCE is defaultly 'y', so
>> mce.o 
>> DOM0 will be compiled by default. Yet we now only support intel 64
>> bit for 
>> DOM0 vMSR. I guess this is the reason why you see those printings.
>> Shall I sent a patch to make stricker limitations for compiling
>> mce.o? 
> 
> I'm not sure if you can avoid compiling mce.o altogether - if that's
> possible, it would certainly be the best approach. If not, some other
> mechanism to suppress the actual hardware touching bits would be
> desirable. 

I plan first send a patch making mce.o compiled for x86_64 Intel arch. 
Since we do plan to make AMD and Intel have a common MCA handling
logic. Both AMD and Intel arch shall support vMSR then. This common
handler might need some time. How do you think?

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0, Ke, Liping <=