WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [SVM]: Make 32bit legacy guests boot again

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [SVM]: Make 32bit legacy guests boot again
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 27 Jun 2009 10:35:20 +0100
Cc:
Delivery-date: Sat, 27 Jun 2009 02:35:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200906261719.55259.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn2cb7ZCEgSixEDTWu9D2s6tPZSVAAmNdxU
Thread-topic: [Xen-devel] [PATCH] [SVM]: Make 32bit legacy guests boot again
User-agent: Microsoft-Entourage/12.19.0.090515
Changeset 19856 is a cleaned up and streamlined version of this patch.
Please take a look. It also fixes a couple of largely theoretical issues:
 * Should depend on EFER.LMA not EFER.LME
 * Should handle the LMA 1->0 transition (i.e., return to legacy mode).

 -- Keir

On 26/06/2009 16:19, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi!
> 
> Attached patch fixes a bug introduced in c/s 19648.
> 
> 32bit legacy guests have the sysenter/sysexit instructions available.
> Therefore, we have to disable intercepts for the sysenter MSRs or the
> guest stucks in an infinite loop of #GPs, otherwise.
> 
> For guests in 64bit mode and 32bit compat mode, sysenter/sysexit instructions
> aren't available. The sysenter MSRs have to be intercepted to make the
> instruction emulation working.
> 
> Attach patch first assumes the guest is in 32bit legacy mode and therefore
> disables the sysenter MSRs in construct_vmcb().
> Access to the MSR_EFER is intercepted. When the guest enables longmode,
> then enable interception of the sysenter MSRs.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel