On Saturday, 27 June 2009 at 01:19, Tim Post wrote:
> Hi,
>
> Building the tip of xen-unstable breaks, at least on x86_32 due to
> warnings being treated as errors with gcc 4.1
>
> The problem is variadic formatting, uint64_t is unsigned long long, yet
> in several places in blktap2 it was formatted as unsigned long.
>
> The attached patch fixes it.
>
> I'm not sure where this was introduced, I just pulled the xen-unstable
> tip 15 minutes ago and noticed it.
>
> diff -r 442fb5f1e0a2 tools/blktap2/drivers/block-ram.c
> +++ b/tools/blktap2/drivers/block-ram.c Sat Jun 27 01:12:22 2009 +0800
> @@ -101,7 +101,7 @@ static int get_image_info(int fd, td_dis
> disksector_size = info->sector_size;
> disksize = info->size;
> diskinfo = info->info;
> - DPRINTF("Image sector_size: \n\t[%lu]\n",
> + DPRINTF("Image sector_size: \n\t[%llu]\n",
> info->sector_size);
This just ping-pongs between breaking 32-bit and 64-bit. I think you
want to use PRIu64 in all these cases.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home