WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] A typo in vram dirty tracking function?

To: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, stefano.stabellini@xxxxxxxxxxxxx
Subject: [Xen-devel] A typo in vram dirty tracking function?
From: Wei Huang <wei.huang2@xxxxxxx>
Date: Wed, 24 Jun 2009 18:01:50 -0500
Cc:
Delivery-date: Wed, 24 Jun 2009 16:02:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.17 (X11/20080914)
Is this a typo? I haven't tried it myself. But did you want to convert logdirty to rw mode?

-Wei

--- a/xen/arch/x86/mm/hap/hap.c Sun Jun 28 22:17:37 2009 -0500
+++ b/xen/arch/x86/mm/hap/hap.c Mon Jun 29 07:43:11 2009 -0500
@@ -90,7 +90,7 @@ int hap_disable_vram_tracking(struct dom

     /* set l1e entries of P2M table with normal mode */
     for (i = dirty_vram->begin_pfn; i < dirty_vram->end_pfn; i++)
-        p2m_change_type(d, i, p2m_ram_rw, p2m_ram_logdirty);
+        p2m_change_type(d, i, p2m_ram_logdirty, p2m_ram_rw);

     flush_tlb_mask(&d->domain_dirty_cpumask);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>