WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] MSR related clean up

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] MSR related clean up
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 24 Jun 2009 10:03:56 +0100
Cc: Eddie Dong <eddie.dong@xxxxxxxxx>
Delivery-date: Wed, 24 Jun 2009 02:04:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200906241650.22488.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn0qNXZjxhAmHdaRkaxH6UR+GjX/gAAd5Cx
Thread-topic: [Xen-devel] [PATCH] MSR related clean up
User-agent: Microsoft-Entourage/12.19.0.090515
On 24/06/2009 09:50, "Sheng Yang" <sheng@xxxxxxxxxxxxxxx> wrote:

> On Thursday 18 June 2009 17:57:06 Sheng Yang wrote:
>> rdmsr_safe() is used to access MSR unknown to Xen, and is not safe... I
>> think it is legacy.
>> 
>> Also let msr_write be parity with msr_read on MSR_IA32_MISC_ENABLE.
>> 
>> CC: Eddie Dong <eddie.dong@xxxxxxxxx>
>> Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
> 
> Keir?

Looks pretty dangerous to me. So I'm not sure. There are various MSRs that
are detected via CPU family/model (which we pass through) which would then
#GP on access. Also this doesn't change the AMD default. Overall, what we
have now does seem to work so I'm reluctant to mess with it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel