[Xen-devel] [patch] fix a bug in condition checking in blktap2

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [patch] fix a bug in condition checking in blktap2
From:	Jun Koi <junkoi2004@xxxxxxxxx>
Date:	Wed, 24 Jun 2009 16:42:57 +0900
Delivery-date:	Wed, 24 Jun 2009 00:43:23 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=KBug8QiorOtHETwWyX7R0r1KzZGWgBDSg4UK2tAC97k=; b=Qfgroohzy77+qxXiGJyZrpUT6/OFV5eiBearYTiyVLUuZXGBfq+MR5pYs9NnOpu0V1 usDRdYX6uir8xfALydsgyuovtrBD/F1VjSrOvFpB8Vf8qyWlWO5zVVr/tugoH6am1D0S 4k25ODj+fiDOUdWbGvvh+kOxm+Rp5x/K+6+4k=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=iuY0FnNLNLR6ScFZcz4WnQ9zIRRT4r0NuZjJ4qAzLEeRN3kZCNU70VolIfQ0ZZztXk K1xlF+oRLBTAr58j59B0+mBngoslHdY8V2unItx/H47FQH/eAL/uHcSArHqoCxEDyqFX gQTTCrUOml4loJpeXQGfw6Bz4jQyThGmbODNg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Looks like an obvious bug in arithmetic condition checking.

Signed-off-by: Jun Koi <junkoi2004@xxxxxxxxx>

--- a/tools/blktap2/drivers/lock.c      Tue Jun 23 17:32:07 2009 +0100
+++ b/tools/blktap2/drivers/lock.c      Wed Jun 24 16:39:23 2009 +0900
@@ -250,7 +250,7 @@
                         }
                 }
                 dptr = readdir(pd);
-                if (!dptr & errno) {
+                if (!dptr && errno) {
                     *ioerror = EIO;
                 }
         }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] [patch] fix a bug in condition checking in blktap2