WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] TSC scaling for live migration between platforms

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] TSC scaling for live migration between platforms with different TSC frequecies
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Wed, 24 Jun 2009 09:18:00 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Levon <levon@xxxxxxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, John
Delivery-date: Tue, 23 Jun 2009 18:20:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6666A68.8268%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <706158FABBBA044BAD4FE898A02E4BC201BD7DC310@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C6666A68.8268%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnvwGrBg+4kDTqFR/KfIVHgiCk9gADIUIwAAEKNZDsAHxo+AA==
Thread-topic: [Xen-devel] [PATCH] TSC scaling for live migration between platforms with different TSC frequecies
Keir Fraser wrote:
> Stuffing the guest freq in a save-image pad field is not backward
> compatible. Old images will not have that field filled in and you'll
> probably end up doing something stupid like give them a zero-hertz
> TSC. Please think about backward compatibility and use a separate

Hi, Keir
    I also checked the filed to solve the backward compatibility issue, and 
once found the field is zero, we won't do anything about TSC scaling(reference 
hvm_gtsc_need_scale to get the detail), so guest never uses a zero-hertz 
frequency in any case.  You know, since old images can't provide TSC frequency 
info, so TSC scaling logic shouldn't cover it.  
Xiantao

>  -- Keir
> 
> On 22/06/2009 06:14, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> wrote:
> 
>> Hi, Keir
>> This is the new version which has addressed the comments from the
>> mailing list. Please review it again.  Thanks!
>> Xiantao
>> 
>> Zhang, Xiantao wrote:
>>> Hi, Keir
>>> 
>>>     This patchset targets for enabling TSC scaling in software for
>>>     live migration between platforms with different TSC frequecies.
>>> Once found the target host's frequency is different with source
>>> host's, hypervisor will trap and emulate guest's all rdtsc
>>> instructions with its expected frequency. If hardware's TSC
>>> frequency is difffernt with guest's exepcted freq, guest may behave
>>> abnormally, eg. incorrect wallclock, soft lockup, even hang in some
>>> cases. Therefore, this patchset is necessary to avoid such issues.
>>> 
>>> PATCH 0001-- Save guest's preferred TSC in image for save/restore
>>> and migration PATCH 0002-- Move multidiv64 as a library function.
>>> PATCH 0003-- Scaling host TSC freqeuncy patch.
>>> 
>>> Signed-off-by Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
>>> Xiantao


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel