WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Baffled by multipage_allocation_permitted()

To: Dave McCracken <dcm@xxxxxxxx>, Xen Developers List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Baffled by multipage_allocation_permitted()
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 15 Jun 2009 22:57:03 +0100
Cc:
Delivery-date: Mon, 15 Jun 2009 14:57:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200906151644.51978.dcm@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnuAplH4th1Rva8SbCyk1/mp0sArwAAZ3qW
Thread-topic: [Xen-devel] Baffled by multipage_allocation_permitted()
User-agent: Microsoft-Entourage/12.19.0.090515
On 15/06/2009 22:44, "Dave McCracken" <dcm@xxxxxxxx> wrote:

> #define multipage_allocation_permitted(d)   \
>    (!rangeset_is_empty((d)->iomem_caps) || \
>     !rangeset_is_empty((d)->arch.ioport_caps))
> 
> I had never tracked down the significance of this macro since it didn't appear
> to be an issue.  Now it's suddenly denying me the ability to work in 2M pages.
> 
> What is this macro trying to achieve?  Why is it necessary?  Is there any
> compelling reason we can't just remove it and allow multipage allocations from
> any domain?

We can just get rid of it I think. There are arguably worse other things we
already allow, like any guest can allocate low memory by specifying a small
value of XENMEMF_address_bits().

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel