tmem 32-on-64 needs (Re: [Xen-devel] [PATCH] tmem cleanup)

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> "Jan Beulich" <JBeulich@xxxxxxxxxx> 15.06.09 15:47 >>>
>- don't mis-use guest handle for passing an MFN value
>- eliminate unnecessary (and misplaced) use of XEN_GUEST_HANDLE_64
>- use copy_from_guest() instead of __copy_from_guest() for loading the
>  argument structure

I ran across these when looking at what changes 32-on-64 support for tmem
would require. However, there's another issue that I didn't feel like 
immediately
sending a patch out for: xen/include/public/tmem.h uses anonymous unions
and structures - all other public headers (with the exception of the declaration
of xenpf_set_processor_pminfo and xen_sysctl_pm_op, which probably are
mistakes/oversights) avoid this (or use it only when it is known to be only
compiled with gcc)) as being a non-standard feature, and the compatibility
header generation script depends on all compound types' fields to be named.

I realize that this will require changes on the client side too, which is why I
first wanted to see if there's anything that I'm overlooking.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel