WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch 11/16] xend: pass-through: Move pciconversionfunc

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch 11/16] xend: pass-through: Move pciconversionfunctions to pci.py
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 15 Jun 2009 19:04:49 +1000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Dexuan Cui <dexuan.cui@xxxxxxxxx>
Delivery-date: Mon, 15 Jun 2009 02:05:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9CC9ED8731C4E5kanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090615015515.927085604@xxxxxxxxxxxx> <20090615015912.912200267@xxxxxxxxxxxx> <9BC9ED7E454F31kanno.masaki@xxxxxxxxxxxxxx> <20090615061559.GA15006@xxxxxxxxxxxx> <9CC9ED8731C4E5kanno.masaki@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 15, 2009 at 04:02:06PM +0900, Masaki Kanno wrote:
> Hi Simon,
> 
> Mon, 15 Jun 2009 16:15:59 +1000, Simon Horman wrote:
> 
> >On Mon, Jun 15, 2009 at 02:58:14PM +0900, Masaki Kanno wrote:
> >Content-Description: Mail message body
> >> Hi Simon,
> >> 
> >> dev_dict_to_sxp method in XendConfig.py is called for both pci 
> >> devices and vscsi devices.  So, I think that the method should 
> >> be not moved to pci.py. 
> >> 
> >> I suggest separating the processing of pci devices and the 
> >> processing of vscsi devices in all_devices_sxpr method. 
> >> I attach a patch for separating them. 
> >
> >That seems reasonable.
> >
> >I haven't had time to work through the vscsi, nor am I likely to in the
> >near future. But does the logic in dev_dict_to_sxp() make sense for vscsi?
> 
> Yes. I confirmed that dev_dict_to_sxp method is working for vscsi.
> 
> 
> >If so, would you be happy it we moved it somewhere else, perhaps
> >into sxp.py? Or create XendSXPDev.py?
> 
> XendSXPDev.py ...

Ok, will do.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>