[Xen-devel] Re: [Qemu-devel] [PATCH] xen: net backend doesn't need linux headers.

[Andreas Färber <andreas.faerber@xxxxxx>]

Am 06.06.2009 um 17:52 schrieb Blue Swirl:

> On 6/2/09, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> > Drop them to make qemu build on OpenSolaris.
> >
> > Cc: Andreas Färber <andreas.faerber@xxxxxx>
> > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> Thanks, applied.
Thanks, the patch helps, but doesn't fully fix the build:

  CC    xen_backend.o
  CC    xen_devconfig.o
  CC    xen_console.o
  CC    xenfb.o
  CC    xen_disk.o
In file included from /export/home/andreas/QEMU/qemu/hw/xen_disk.c:43:
/export/home/andreas/QEMU/qemu/hw/xen_blkif.h:20: warning: #pragma  
pack(push[, id], <n>) is not supported on this target
/export/home/andreas/QEMU/qemu/hw/xen_blkif.h:36: warning: #pragma  
pack(pop[, id], <n>) is not supported on this target
  CC    xen_nic.o
/export/home/andreas/QEMU/qemu/hw/xen_nic.c: In function  
`net_tx_packets':
/export/home/andreas/QEMU/qemu/hw/xen_nic.c:179: error: `PAGE_SIZE'  
undeclared (first use in this function)
/export/home/andreas/QEMU/qemu/hw/xen_nic.c:179: error: (Each  
undeclared identifier is reported only once
/export/home/andreas/QEMU/qemu/hw/xen_nic.c:179: error: for each  
function it appears in.)
make: *** [xen_nic.o] Error 1

A quick search for PAGE_SIZE revealed some posts saying that PAGE_SIZE  
shouldn't be used in userland and be replaced with getpagesize().  
Looking at the code though I see a number of XC_PAGE_SIZE that don't  
result in errors. Might PAGE_SIZE be a typo then?
Andreas


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel