Re: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] blktap2: need more than 3 values to unpack)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 03/06/2009 22:17, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>>  1. It only adds extra functionality which by default would
>> not do anything.
>> Just reading the patch I can see it's harmless by itself as it merely
>> introduces a new notifier chain which noone registers on.
> 
> I won't pretend to understand the code, but I did
> reproduce the problem with 881 by itself and with
> 889 with 881 reverted.

I can't explain that from reading the code. It looks like a no-op to me
unless the new function bus_register_notifier() is called.

>>  2. Changeset 882 depends on 881. If you revert just 881 then
>> the tree will not build.
> 
> This doesn't appear to be the case for me, though
> I'm certainly willing to believe there's something
> wrong with my process:

Actually I missed that the dependent code is only built if
CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got one or both
disabled and hence 882 doesn't break without 881 in your case.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel