WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [xenstat] Use backend path which is compatible with pvops --

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: [Xen-devel] [xenstat] Use backend path which is compatible with pvops -- status request
From: Daniel Schroeder <sec@xxxxxxxxxxxxxxx>
Date: Mon, 25 May 2009 11:24:56 +0200
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Valtteri Kiviniemi <valtteri.kiviniemi@xxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 25 May 2009 02:25:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1241773407.16804.39.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <49FFD4C1.9070803@xxxxxxxxxxxx> <4A00ACEB.1070904@xxxxxxxx> <4A032CB0.1060803@xxxxxxxxxxxx> <1241773407.16804.39.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090321)
Ian Campbell wrote:
> On Thu, 2009-05-07 at 14:47 -0400, Valtteri Kiviniemi wrote:
>> Hi,
>>
>> Yeah, so it seems to be:
> 
> The switch to/from curses has hidden most of the interesting stuff
> (including a useful error message :-(), if you redirect to a file you
> get:
> open("/sys/devices/xen-backend/", 
> O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY) = -1 ENOENT (No such file or 
> directory)
> dup(2)                                  = 6
> fcntl64(6, F_GETFL)                     = 0x8001 (flags O_WRONLY|O_LARGEFILE)
> close(6)                                = 0
> write(2, "Error opening /sys/devices/xen-b"..., 67Error opening 
> /sys/devices/xen-backend/: No such file or directory
> ) = 67
> 
> This path doesn't exist in the pvops kernel. Looks
> like /sys/bus/xen-backend/devices is just as good and exists in both
> pvops and 2.6.18 kernels.
> 
> Subject: xenstat: Use backend path which is compatible with pvops and 
> 2.6.18-xen kernels.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> diff -r 07812e857e67 tools/xenstat/libxenstat/src/xenstat_linux.c
> --- a/tools/xenstat/libxenstat/src/xenstat_linux.c    Thu Apr 09 12:09:14 
> 2009 +0100
> +++ b/tools/xenstat/libxenstat/src/xenstat_linux.c    Fri May 08 09:40:45 
> 2009 +0100
> @@ -31,7 +31,7 @@
>  
>  #include "xenstat_priv.h"
>  
> -#define SYSFS_VBD_PATH "/sys/devices/xen-backend/"
> +#define SYSFS_VBD_PATH "/sys/bus/xen-backend/devices"
>  
>  struct priv_data {
>       FILE *procnetdev;
> 
> 

ping
whats the status of this patch? Will it hit xen-unstable repo anytime soon?

daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel