Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Stefano Stabellini, le Thu 21 May 2009 14:17:11 +0100, a écrit :
> Samuel Thibault wrote:
> > Stefano Stabellini, le Thu 21 May 2009 12:40:52 +0100, a écrit :
> >> The first and last sector as well as the sector number of the request is
> >> expressed in 512 bytes units, independently from the real sector size.
> >>      req->id = (uintptr_t) aiocbp;
> >> -    req->sector_number = aiocbp->aio_offset / dev->info.sector_size;
> >> +    req->sector_number = aiocbp->aio_offset / 512;
> >>  
> > 
> > Oh?!
> > 
> > That needs to be better documented in xen/include/public/io/blkif.h,
> > then.  I'm however wondering whether this shouldn't actually be fixed in
> > the blkback/cdrom interface instead.
> > 
> 
> Yeah, I am surprised as you are, but the linux blkfront does the same
> thing so I prefer to avoid changing the protocol now.

Well, it's not about changing the protocol, it's about fixing drivers
doing the wrong thing according to the documentation.  What is the use
of the xenstore sector_size value if not here?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel