WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: don't map more than the allocated space for

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: don't map more than the allocated space for frame_table
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 20 May 2009 06:56:04 -0700
Cc:
Delivery-date: Wed, 20 May 2009 06:56:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A1421A80200007800001CB1@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnZTvFZdpkKmTtBQsyLafZ8oEgaOgAA8XP5
Thread-topic: [Xen-devel] [PATCH] x86: don't map more than the allocated space for frame_table
User-agent: Microsoft-Entourage/12.17.0.090302
On 20/05/2009 06:28, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Also, make frame_table a 'mostly read' variable. Actually, I don't
> really understand why this has to be a variable on x86 at all -
> address calculations involving it could be cheaper if this was just
> a #define. Perhaps kexec is the only thing that needs this to be a
> variable, but if that indeed is the only reason, kexec should define
> its own static variable.

Would it really be much cheaper? Pointer load versus a 64-bit constant? If
you're sure it would be an improvement I would take a patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>