WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest c

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest config file
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 15 May 2009 14:01:00 +0100
Cc:
Delivery-date: Fri, 15 May 2009 06:01:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457501C990A93A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnVUKywB4Q5NpcfRuKxiLcTkuwu4gAAdlgcAAAAM6AAAqq4Vg==
Thread-topic: [PATCH] disallow duplicate pci device strings in guest config file
User-agent: Microsoft-Entourage/12.17.0.090302
On 15/05/2009 12:52, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> Keir Fraser wrote:
>> Why is the right answer not: Don't do that, then?
> Yes, normally a user should never do that.
> However, if a user really does that somehow(e.g., by mistake), without the
> small patch, the user may not notice the mistake in time and may be surprised
> when strange things happen (e.g., inside guest, 'lspci' shows 2 same devices;
> or guest may crash at some uncertain time point).
> So, I think the small patch is useful.

Post 3.4 then. I don't know enough about Python conversion rules to be sure
on this one for 3.4.0.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel