WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix get_page_from_l1eandcleanup_page_cacheattr to use PGC_cacheattr_mask
From: Patrick Colp <Patrick.Colp@xxxxxxxxxx>
Date: Fri, 15 May 2009 10:56:34 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 15 May 2009 02:57:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A0D57F50200007800001153@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A0D529E0200007800001120@xxxxxxxxxxxxxxxxxx> <C632F732.B26E%keir.fraser@xxxxxxxxxxxxx> <4A0D57F50200007800001153@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090409)
Jan Beulich wrote:
Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 15.05.09 11:40 >>>
On 15/05/2009 10:31, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

Patrick Colp <Patrick.Colp@xxxxxxxxxx> 15.05.09 11:01 >>>
# HG changeset patch
# User Patrick Colp <Patrick.Colp@xxxxxxxxxx>
# Date 1242295647 -3600
# Node ID c5098f5c5caf4174bd2e46d49d7b65109203f7c5
# Parent  2522cc95efd2f3fadf7342d18fe86e8f37f89c2a
Fix get_page_from_l1e and cleanup_page_cacheattr to use PGC_cacheattr_mask.
Could you indicate what it is that you fix here?
I assume it's just getting rid of the open-coded 7.

So would I have thought by looking at the patch, but the word 'fix' in the 
subject
made me thing there was something more subtle that I didn't spot...

Jan

Nah, just a poor word choice. "Changed" would probably have been better.


Patrick


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel