WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] vmx_update_guest_cr() losing EXCEPTION_BITMAP setting

To: "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] vmx_update_guest_cr() losing EXCEPTION_BITMAP setting
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 11 May 2009 07:52:27 +0100
Cc:
Delivery-date: Sun, 10 May 2009 23:53:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <469F2699A483D44BA6D2B311B1089D3A5F115E44FF@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnR8XOAYOeTv7J5Qqms8GGZVbPMcQAE5g3C
Thread-topic: [Xen-devel] vmx_update_guest_cr() losing EXCEPTION_BITMAP setting
User-agent: Microsoft-Entourage/12.17.0.090302
On 11/05/2009 05:32, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx> wrote:

> Running a heavily modified xen-unstable changset 19590:f80cf52a4fb6 with
> debugger_attached set, I was seeing the debug traps getting lost from the
> EXCEPTION_BITMAP in vmx_update_guest_cr() when transitioning from real to
> protected mode.  In my codebase, I could fix this trivially by clearing the
> debug_state_latch and letting vmx_do_resume() reapply the setting. However,
> while it looks like a valid issue in the unmodified codebase, I'm not sure. So
> maybe someone might test/examine it and decide if it is real and whether some
> more complex fix is required?

In vmx_update_guest_cr(), where EXCEPTION_BITMAP gets reset after exit from
real mode, try setting v->arch.hvm_vcpu.debug_state_latch=0 and
raise_softirq(SCHEDULE_SOFTIRQ).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel