[Xen-devel] Re: [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr

[Ingo Molnar <mingo@xxxxxxx>]

* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> +/* DOM0 TODO: Need to fill in the remaining mtrr methods to have full
> + * working userland mtrr support. */
> +static struct mtrr_ops xen_mtrr_ops = {
> +     .vendor            = X86_VENDOR_UNKNOWN,
> +//   .set               = xen_set_mtrr,
> +//   .get               = xen_get_mtrr,
> +     .get_free_region   = generic_get_free_region,
> +//   .validate_add_page = xen_validate_add_page,
> +     .have_wrcomb       = positive_have_wrcomb,
> +     .use_intel_if      = 0,
> +     .num_var_ranges    = xen_num_var_ranges,
> +};

Please dont post patches with ugly TODO items in them.

Also, a more general objection is that /proc/mtrr is a legacy 
interface, we dont really want to extend its use. The Xen hypervisor 
should get proper PAT support instead ...

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel