|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [PATCH][ioemu] fix PCI bar mapping
To: |
Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx> |
Subject: |
[Xen-devel] Re: [PATCH][ioemu] fix PCI bar mapping |
From: |
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
Date: |
Thu, 7 May 2009 12:12:12 +0100 |
Cc: |
"Zhao, Yu" <yu.zhao@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> |
Delivery-date: |
Thu, 07 May 2009 04:12:39 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20090507163136.983F.27C06F64@xxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<EADF0A36011179459010BDF5142A45751555F260@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090507163136.983F.27C06F64@xxxxxxxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Yuji Shimada writes ("Re: [PATCH][ioemu] fix PCI bar mapping"):
> pt_pci_read_config should not be used to read configuration registers.
> pt_pci_read_config emulates access to read the registers from guest
> software. Many functions which are not relevant are executed in
> pt_pci_read_config. So side effects may occur. Instead, you can use
> pc_read_word of libpci just to read configuration registers.
Should we be reverting Cui's patch and fix the problem some other
way ?
> Or, there is another approach. It is that you remove emu_mask from
> writable_mask in pt_cmd_reg_write. Then you can get the proper value
> from reg_entry->data.
It would be nice to get this sorted for the 3.4 release, which is
imminent ...
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|