[Xen-devel] Re: [patch] provide uniqe x2apicid for each vcpu in

To:	Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
Subject:	[Xen-devel] Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Thu, 07 May 2009 08:05:27 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 07 May 2009 00:06:00 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1241647906.4486.6.camel@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcnOl6wyfzpq4YJFQTyo7eCaegOCSQASobL8
Thread-topic:	[patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
User-agent:	Microsoft-Entourage/12.17.0.090302

What's the point of emulating an x2apicid when we don't emulate an x2apic?

 -- Keir

On 06/05/2009 23:11, "Nitin A Kamble" <nitin.a.kamble@xxxxxxxxx> wrote:

> Keir,
> 
> Just like the apicid, x2apicid is also unique to each cpu. x2apicid is
> coming from edx register of the cpuid leaf 0xb.
> 
> Please Apply/comment.
> 
> Signed-Off-By: Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
> 
> 
> diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c
> --- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700
> +++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700
> @@ -1687,6 +1687,10 @@
>          *ebx |= (v->vcpu_id * 2) << 24;
>          if ( vlapic_hw_disabled(vcpu_vlapic(v)) )
>              __clear_bit(X86_FEATURE_APIC & 31, edx);
> +    } else if ( input == 0x0000000b )
> +    {
> +        /* fix the x2apicid */
> + *edx = v->vcpu_id * 2;
>      }
>  }
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [patch] provide uniqe x2apicid for each vcpu in the cpui