WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: next->vcpu_dirty_cpumask checking at the top of context_

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: next->vcpu_dirty_cpumask checking at the top of context_switch()
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 16 Apr 2009 17:08:13 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 16 Apr 2009 09:08:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49E767F5.76EA.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acm+piR+v8U8J6EgQ+KM8kPL02RJCAAB2aqc
Thread-topic: next->vcpu_dirty_cpumask checking at the top of context_switch()
User-agent: Microsoft-Entourage/12.17.0.090302
On 16/04/2009 16:16, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Bottom line question is - can't the second !cpus_empty() check go away
> altogether, and shouldn't the argument passed to flush_tlb_mask() be
> dirty_mask instead of next->vcpu_dirty_cpumask?

If you think cpus_empty() checks/warns/bugs could do with sanitising, please
send that on separately from other performance-related changes. And I'll let
you know what I think of it when I can see the all the details.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>