Re: [Xen-devel] qemu repositories

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Mark Johnson writes ("[Xen-devel] qemu repositories"):
> "hw/vga.c" line 1228 of 2832 --43%-- col 31
> --
>    static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS];
> 
> "hw/vga.c" line 1492 of 2832 --52%-- col 31
> --
> static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS] = {
>     rgb_to_pixel8_dup,

The earlier declaration is necessary because the table is referred to
in the intervening code.  My compiler doesn't warn about this.

Can you try this change and let me know if it helps ?

Thanks,
Ian.

diff --git a/hw/vga.c b/hw/vga.c
index 7b8572a..71cbcc2 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1225,7 +1225,7 @@ static const uint8_t cursor_glyph[32 * 4] = {
 
 typedef unsigned int rgb_to_pixel_dup_func(unsigned int r, unsigned int g, 
unsigned b);
 
-static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS];
+static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[];
 
 /*
  * Text mode update

-- 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel