 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] do_domctl and EAGAIN
| To: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] do_domctl and EAGAIN |
| From: | Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> |
| Date: | Tue, 07 Apr 2009 09:41:06 +0200 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 07 Apr 2009 00:41:32 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1239090154; x=1270626154; h=from:sender:reply-to:subject:date:message-id:to:cc: mime-version:content-transfer-encoding:content-id: content-description:resent-date:resent-from:resent-sender: resent-to:resent-cc:resent-message-id:in-reply-to: references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; z=From:=20Juergen=20Gross=20<juergen.gross@xxxxxxxxxxxxxx> |Subject:=20Re:=20[Xen-devel]=20do_domctl=20and=20EAGAIN |Date:=20Tue,=2007=20Apr=202009=2009:41:06=20+0200 |Message-ID:=20<49DB0392.2060103@xxxxxxxxxxxxxx>|To:=20Ke ir=20Fraser=20<keir.fraser@xxxxxxxxxxxxx>|CC:=20"xen-deve l@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@xxxxxxxxxxxxxxxxxxx> |MIME-Version:=201.0|Content-Transfer-Encoding:=207bit |In-Reply-To:=20<C600BD39.80CC%keir.fraser@xxxxxxxxxxxxx> |References:=20<C600BD39.80CC%keir.fraser@xxxxxxxxxxxxx>; bh=57kGsmG863VQAtdEShiNJsEBDcx9fT1kBKeUEdLTN2Q=; b=pX6gWFAmYev5z0a+NruWI92PUkVHsqaaunBYuxs2gpZ4MOMiuZulocAV 6MKyEcksgnRzh1IKl5mnT8tm84Jpvew/7LVW7UdDRDoQzLkG/1tPgMX45 s8RY39rm4sk5H60jUIVkWpGCwqXKhjwiS3cZxAzw3HgEt+kPfWBPoEOJP wwHX/bmw80bDN4l6cClqhOEDKmGFMwwLrqyWOvfvUZp0q7c+q1gFrzLmm 8KnAkvBZFYJywreuk0BX8apGfpV9W; |
| Domainkey-signature: | s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type: Content-Transfer-Encoding; b=YUWwJk2+xg+l8uBt29eFR60gRE56zU7TLIaTZOq2gADARS5wN7qZtTsT JSw6E6g3KPpDCAY/9oHVGmNhsA0CPRSTc0wfb0VFN+1f61kHxdDSTKJLo iYrl7OZiVOHp/PBZAsAuyRj79zE0jVzqJP/IHWbfiaYZDSnE6/WCjn/8g o8AmEGe0iLvd+RZrJU2Dk+ld5XgOT+Yx43bXNfpOog+pSg0T4lgXjMmJF 46tJRhF9vYbZWc2UNX6O+FW8N0+3V; |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C600BD39.80CC%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Organization: | Fujitsu Technology Solutions |
| References: | <C600BD39.80CC%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mozilla-Thunderbird 2.0.0.19 (X11/20090103) |
Keir Fraser wrote: > Only DOMCTL_destroydomain returns EAGAIN. No domctl returns EINTR. do_domctl uses ioctl. ioctl can return EINTR if a signal is caught. Other hypercalls do return EAGAIN. Juergen > > -- Keir > > On 07/04/2009 08:04, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote: > >> Hi, >> >> certain domctl hypercalls (and possibly others as well) might fail with errno >> EAGAIN. This case seems to be tested only in very few places, e.g. in >> xc_domain_destroy. >> >> Is there any reason why this case isn't handled in do_domctl? >> Shouldn't EINTR be handled as well? >> >> The other solution would be to have two versions of do_domctl, one of them >> looping in case of EAGAIN or EINTR. >> >> I suspect this lack of errno-testing could lead to very sporadic failures... -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 636 47950 Fujitsu Technolgy Solutions e-mail: juergen.gross@xxxxxxxxxxxxxx Otto-Hahn-Ring 6 Internet: ts.fujitsu.com D-81739 Muenchen Company details: ts.fujitsu.com/imprint.html _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [RFC] [PATCH] Memory allocation from the nearest node., Yuji Shimada |
|---|---|
| Next by Date: | Re: [Xen-devel] do_domctl and EAGAIN, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] do_domctl and EAGAIN, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] do_domctl and EAGAIN, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
