WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen: explicitly zero CR[1] in getvcpucontext for gue

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xen: explicitly zero CR[1] in getvcpucontext for guests with no User PT
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Mon, 06 Apr 2009 10:51:02 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 06 Apr 2009 02:51:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Some recent guests (SLES11 & PVOPS) set this to NULL when running
idle/kernel threads and the uninitialised value can confuse
suspend/resume.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r e54eeff2de54 -r fbc48e7d7ede xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c     Fri Mar 27 11:07:11 2009 +0900
+++ b/xen/arch/x86/domctl.c     Fri Apr 03 11:41:21 2009 +0100
@@ -1151,6 +1151,8 @@
             if ( !pagetable_is_null(v->arch.guest_table_user) )
                 c.nat->ctrlreg[1] = xen_pfn_to_cr3(
                     pagetable_get_pfn(v->arch.guest_table_user));
+            else
+                c.nat->ctrlreg[1] = 0UL;
 #endif
 
             /* Merge shadow DR7 bits into real DR7. */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xen: explicitly zero CR[1] in getvcpucontext for guests with no User PT, Ian Campbell <=