Re: [Xen-devel] [PATCH] only set scheduler timer for non-idle CP

To:	Thomas Pfeuffer <thomas.pfeuffer@xxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Thu, 02 Apr 2009 14:06:27 +0100
Cc:
Delivery-date:	Thu, 02 Apr 2009 06:06:58 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<49D4B41C.9030901@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcmzkXHgTPa/n0P0RNGJeQlT9mWitQAAmMDU
Thread-topic:	[Xen-devel] [PATCH] only set scheduler timer for non-idle CPU
User-agent:	Microsoft-Entourage/12.15.0.081119

On 02/04/2009 13:48, "Thomas Pfeuffer" <thomas.pfeuffer@xxxxxxxx> wrote:

Hello Ke,

It is not necessary to set scheduler timer for idle CPU. so this patch add conditional check for idle CPU.

I think your patch is not good in case sedf-scheduler is used. If idle VCPU is the current "running" VCPU, the scheduler timer is set to the next "period begin" of the first VCPU in the wait queue.
Your patch prevents sedf from taking the VCPUs waiting for their next period into the runnable queue again.

It’s probably cleaner always to respect the specific scheduler’s scheduling quantum in schedule.c, but then have sched_credit.c return a very large quantum (large as possible) for the idle VCPU.

-- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] only set scheduler timer for non-idle CPU