WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Tue, 31 Mar 2009 10:24:25 -0700
Cc: andy@xxxxxxxxx
Delivery-date: Tue, 31 Mar 2009 10:24:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ed51e0ec7b8c08b1f191.1238518391@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: xen-devel@xxxxxxxxxxxxxxxxxxx, andy@xxxxxxxxx
References: <ed51e0ec7b8c08b1f191.1238518391@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-03-28)
On Tuesday, 31 March 2009 at 09:53, Brendan Cully wrote:
> Skip vcpu_hotplug for VCPU 0 in smp_resume.
> This function can occasionally take up to 2 seconds to complete,
> and smp_suspend also skips VCPU 0.

I'm doing a bit of testing ahead of releasing Remus, and I've noticed
that there are a couple of places where resuming from suspension can
get stuck for a long time, which can cause Remus to think that the
domain has died. This is one of them.

The other is in the netfront accelerator. It tears down a xenstore
watch on the accelerator path at every suspend, and adds the watch
back on resume. As with any xenstore interaction, this can
occasionally take a very long time. I'm going from faulty memory here,
but I didn't think it was necessary to tear down and restore watches
across suspend. Would it make sense to move the watch remove and add
into the resume hook (taking it completely out of suspend and
suspend_cancel)?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>