WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen: panic rather than BUG if an error is encountere

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xen: panic rather than BUG if an error is encountered decompressing a bzImage
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 06 Mar 2009 08:19:46 +0100
Cc: jeremy@xxxxxxxx
Delivery-date: Fri, 06 Mar 2009 00:20:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1236327532 0
# Node ID f3c3aed8177e176619ebc285b9815e5478b595d8
# Parent  68a08b6e0200308a3e31688d170043087e66b7af
xen: panic rather than BUG if an error is encountered decompressing a bzImage

This gives a more useful error message without an unnecessary stack dump.

Noticed by Jeremy Fitzhardinge.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 68a08b6e0200 -r f3c3aed8177e xen/arch/x86/bzimage.c
--- a/xen/arch/x86/bzimage.c    Thu Mar 05 09:54:33 2009 +0000
+++ b/xen/arch/x86/bzimage.c    Fri Mar 06 08:18:52 2009 +0000
@@ -58,8 +58,7 @@ static void flush_window(void);
 
 static __init void error(char *x)
 {
-    printk("%s\n", x);
-    BUG();
+    panic("%s\n", x);
 }
 
 static __init int fill_inbuf(void)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xen: panic rather than BUG if an error is encountered decompressing a bzImage, Ian Campbell <=