WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] txt: Fix return code for S3 integrity

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] txt: Fix return code for S3 integrity
From: "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>
Date: Thu, 5 Mar 2009 15:43:17 -0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Wang, Shane" <shane.wang@xxxxxxxxx>
Delivery-date: Thu, 05 Mar 2009 15:43:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acmd7Chise3tbIbHSFyIVHqrRmDusw==
Thread-topic: [PATCH] txt: Fix return code for S3 integrity
The original patch left in a debug return value from one of the memory 
integrity checks.  This patch returns the correct error code in case of a 
failure.  This was re-tested to ensure that it still passes for the expected 
case.

Signed-off-by: Joseph Cihula <joseph.cihula@xxxxxxxxx>

diff -r 7f573cb76db4 xen/arch/x86/tboot.c
--- a/xen/arch/x86/tboot.c      Tue Mar 03 13:22:28 2009 +0000
+++ b/xen/arch/x86/tboot.c      Thu Mar 05 14:31:47 2009 -0800
@@ -450,7 +450,7 @@ int tboot_s3_resume(void)

     tboot_gen_domain_integrity(g_tboot_shared->s3_key, &mac);
     if ( mac != domain_mac )
-        return 0; /* -3 */
+        return -3;

     return 0;
 }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] txt: Fix return code for S3 integrity, Cihula, Joseph <=