WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] page_list_splice

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] page_list_splice
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 05 Mar 2009 20:46:06 +0000
Cc:
Delivery-date: Thu, 05 Mar 2009 12:46:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f6f7b32a-8772-4dd7-ba39-7a726020e24f@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acmd0Ebj7wa7kQnZTC6WuOjxgYtRMAAAyDMG
Thread-topic: [Xen-devel] page_list_splice
User-agent: Microsoft-Entourage/12.15.0.081119
On 05/03/2009 20:23, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Without this clause, I get a null-pointer (actually null+4)
> dereference... I think I must be missing some basic
> difference between normal list code and page_list code.

An empty list has NULL pointers in its list_head. You therefore set at=NULL,
and then dereference at->list.prev later. So I guess you do need that second
if stmt.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>