WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH]xend: fix a typo in pci.py

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH]xend: fix a typo in pci.py
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Mon, 2 Mar 2009 11:29:35 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Delivery-date: Sun, 01 Mar 2009 19:31:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457507916F6D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmWK7Ay/E5vXOsoRn+rbAvDfn4T5wCl5gBAAIiuVXA=
Thread-topic: [PATCH]xend: fix a typo in pci.py
Hi Keir,
For the first patch, please use the attached new version: 01_new_fix_d3d0.patch.
This new version keeps the correct 0.01s recovery time for D3hot/D0 transition 
(in the previous version, it was changed to 0.1s by accident).

Thanks,
-- Dexuan

-----Original Message-----
From: Cui, Dexuan 
Sent: 2009年2月27日 18:31
To: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH]xend: fix a typo in pci.py

Cui, Dexuan wrote:
> The PCI_EXP_TYPE_PCI_BRIDGE should be PCI_EXP_FLAGS_TYPE here.
> Also a tiny fix to the python comment.

Please ignore the patch of the previous mail and use the attachments of this 
mail:

[01_fix_d3d0.patch]
Fix some mistakes in tools/python/xend/util/pci.py
1) PCI_PM_CTRL_NO_SOFT_RESET: this is bit3 of PMCSR(Power Management 
Control/Status). It should be 8. This bit means a device's capability of not 
doing an internal reset across D3hot/D0.
If the bit is 1, there shall be no reset across D3hot/D0, so we should not use 
it as a method to reset device.
2) When performing reset, we should sleep at least 100ms; in current code, it's 
incorrect somewhere we sleep 0.2s and somewhere 0.01s.
3) In detect_dev_info(), fix a typo: PCI_EXP_TYPE_PCI_BRIDG -> 
PCI_EXP_FLAGS_TYPE.
4) fix a small typo in the comment of transform_list().

[02_fix_xen_no_soft_reset.patch]
Fix the definition of PCI_PM_CTRL_NO_SOFT_RESET. This is bit3 of PMCSR(Power 
Management Control/Status). It should be 8.

[03_fix_dom0_no_soft_reset.patch]
Fix the definition of PCI_PM_CTRL_NO_SOFT_RESET. This is bit3 of PMCSR(Power 
Management Control/Status). It should be 8.


Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Attachment: 01_new_fix_d3d0.patch
Description: 01_new_fix_d3d0.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>