| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH-0/2] Hypervisor profiling using GCOV (64bit Hyper
Hi,
Tej wrote:
Sending Patches for the 64 bit Hypervisor, We have tested patches on
AMD-64 (Athlon(tm) 64 X2 Dual Core Processor 4600+) machine with
gcc-4.2 & gcc-3.4. Please refer the previous GCOV RFC in same mail for
more info on Hypervisor profiling.
We have added support to 32bit and 64bit Kernel.
In addition to patches for hypervisor profiling, we did a little work
on *lcov* to work with hypervisor.
README could be useful, for naive lcov user. locv-diff.patch show our
change in lcov scripts.
any comments, feedback and suggestion are more than welcome
While I still need to test the patch (building 3.3 right now) and to
understand gcov internals, I think that a few comments can be done,
mostly aestethicals.
- xen coding style: Using four-spaces tabs is generally the tradition.
Also I do prefer to have brackets that start code blocks on a new line
aligned to the previous line, but that's not followed everywhere in the
code.
- Makefiles: while the num=$*.c is still a mystery to me, my question
is: do you really need to make links with different names to files
compiled multiple times? If so, it would be useful to remove them on
'make clean'.
Also, it would be useful to make this feature enabled with a
compile-time option.
More comments to follow as I test it.
Thanks,
Gianluca
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home