WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Build vmlinuz-2.6.29-rc5-tip

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Andrew Lyon <andrew.lyon@xxxxxxxxx>
Subject: Re: [Xen-devel] Build vmlinuz-2.6.29-rc5-tip
From: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Date: Fri, 20 Feb 2009 11:59:56 -0800 (PST)
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Marc - A. Dahlhaus \[ Administration | Westermann GmbH \]" <mad@xxxxxx>
Delivery-date: Fri, 20 Feb 2009 12:00:31 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1235159996; bh=NfrAXd+e40WPqGngwkyatJ3kdtGA5DIEGKlxEf1MZq8=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=tMH1Kyvy+1BWL3iazr79jCGwbS2/h9Oon9EeZrq6b5/lgn14gERSZgBHv4Gy9WeuBoUl2IUa+AupclmwaqVP2QcaWVMRfrPUPXevAhcOW39gAXixfCjpJIPFQVIgPtYOVbKKIsdoj/+jVLOiJ8IVmYlNkHQLY2EV6lr7CC27eUg=
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=cfjaIFL6zWyTMmMFjVXZ4wEpuv3+RCZAMB4I9Pa80uMRkPfnz9bnhiERdlmbf4dgIyoL0KDwvqeN/nsce+CU2vUTKI5RiTXx8A/Ykgs/FfN3q41GNi4xjSSvVDtht1p/5/4fmE6Hmocnh1po6tr+nS+24L9psl3qHOon88hbrjo=;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f4527be0902201144y33198820n5e081bf4d729de4e@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: bderzhavets@xxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>I have checked the ioemu-remote source that is downloaded when
>building xen unstable, it seems to be missing this patch:

> <snip>

> This patch fixes the segmentation fault on assigning device without
> Power Management Capability Structure.
************************************************
Where to get <snip> for patching Xen Unstable ?

Boris.
************************************************
> Please apply this patch after applying the following patch I have
> submitted.

[PATCH] ioemu: Cleanup the code of PCI passthrough.

Thanks,
--
Yuji Shimada.


Signed-off-by: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>


diff --git a/hw/pass-through.c b/hw/pass-through.c
index 855f69c..305ea59 100644
--- a/hw/pass-through.c
+++ b/hw/pass-through.c
@@ -1165,7 +1165,7 @@ static void pt_pci_write_config(PCIDevice *d,
uint32_t address, uint32_t val,
}

/* check power state transition flags */
- if (pm_state->flags & PT_FLAG_TRANSITING)
+ if (pm_state != NULL && pm_state->flags &
PT_FLAG_TRANSITING)
/* can't accept untill previous power state transition is
completed.
* so finished previous request here.
*/
@@ -1280,7 +1280,7 @@ out:
if (!ret)
PT_LOG("Error: pci_write_block failed. return
value[%d].\n", ret);

- if (pm_state->flags & PT_FLAG_TRANSITING)
+ if (pm_state != NULL && pm_state->flags &
PT_FLAG_TRANSITING)
/* set QEMUTimer */
qemu_mod_timer(pm_state->pm_timer,
(qemu_get_clock(rt_clock) + pm_state->pm_delay));
@@ -1337,7 +1337,7 @@ static uint32_t pt_pci_read_config(PCIDevice *d,
uint32_t address, int len)
}

/* check power state transition flags */
- if (pm_state->flags & PT_FLAG_TRANSITING)
+ if (pm_state != NULL && pm_state->flags &
PT_FLAG_TRANSITING)
/* can't accept untill previous power state transition is
completed.
* so finished previous request here.
*/

From where ? <snip>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>