WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: pv_ops parport trouble

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: pv_ops parport trouble
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Thu, 19 Feb 2009 17:31:38 +0100
Cc: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 19 Feb 2009 08:32:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <499D878F.4070906@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C5C33459.314B%keir.fraser@xxxxxxxxxxxxx> <499D878F.4070906@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Jeremy Fitzhardinge wrote:
> I guess that's possible, but the code in question does just pass the
> trigger and polarity straight through.

Notice:
  #define ACPI_LEVEL_SENSITIVE            (u8) 0x00

whereas for the io apic 0 == edge.

cheers,
  Gerd


diff --git a/arch/x86/xen/pci.c b/arch/x86/xen/pci.c
index d661c74..62ab389 100644
--- a/arch/x86/xen/pci.c
+++ b/arch/x86/xen/pci.c
@@ -53,7 +53,7 @@ int xen_register_gsi(u32 gsi, int triggering, int polarity)
        printk(KERN_DEBUG "xen: --> irq=%d\n", irq);
 
        if (irq > 0)
-               xen_set_io_apic_routing(irq, triggering, polarity);
+               xen_set_io_apic_routing(irq, triggering == 
ACPI_LEVEL_SENSITIVE, polarity);
 
        return irq;
 }
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel