 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH ixgbe] Don't depend of skb->data for VMDq
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH ixgbe] Don't depend of skb->data for VMDq |
| From: | Mitch Williams <mitch.a.williams@xxxxxxxxx> |
| Date: | Tue, 17 Feb 2009 16:24:35 -0800 |
| Cc: | steven.smith@xxxxxxxxxxxxx, joserenato.santos@xxxxxx |
| Delivery-date: | Tue, 17 Feb 2009 16:25:06 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=zvtySj1q0fI2cbzhWLsYYqNOooGAf+n67W9fpDde5JE=; b=JYBmdyae+yOvec/AHkBOt0CylOJ79O7MQ4HkE61v3Lxogbmxnt47xQ6y2zHvJkXDrC vt0OBAKiFm24+/DpRbaRJUEeTsK1VkK4JY7fP+Ud2y1g3TfTlBWWANW9kAUwAgBLsWzU /K1qZxa5/zMb7STgSF3gTWP6EF/DSWft+812o= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=BcuI4cbCduxiCl/+iDnDC3beTW2ElAlR0egGNY2PQCdVpNBk2FIhI3kSeZ9yaZJXrh wQb9bjB0DBKp1E2AdEtrOYZC0jYAags/GLpTH4LdidiF0aisHrCh0bdBzRqqH01SjJy8 mV7jQMqX+XXwZwfnNChDlLcBNfmuKFeXXDiTQ= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Occasionally, vmq_alloc_skb() will give us an skb with a nonzero but
bogus data pointer. Dereferencing this pointer will then cause a
panic.
Although we really need to find out where these are coming from, this
patch will enable us to continue development and testing in the short
term.
Signed-off-by: Mitch Williams <mitch.a.williams@xxxxxxxxx>
(Patch is attached as well as inline due to email mangling issues.)
diff -urpN -X dontdiff b/drivers/net/ixgbe/ixgbe_main.c
linux-2.6.18.hg/drivers/net/ixgbe/ixgbe_main.c
--- b/drivers/net/ixgbe/ixgbe_main.c 2009-02-17 13:48:00.000000000 -0800
+++ linux-2.6.18.hg/drivers/net/ixgbe/ixgbe_main.c 2009-02-17
14:06:58.000000000 -0800
@@ -1144,7 +1144,8 @@ static bool ixgbe_clean_rx_irq(struct ix
total_rx_bytes += skb->len;
total_rx_packets++;
#ifdef CONFIG_XEN_NETDEV2_VMQ
- if (skb->data)
+ if (!((adapter->flags & IXGBE_FLAG_VMDQ_ENABLED) &&
+ rx_ring->queue_index))
#endif
skb->protocol = eth_type_trans(skb, adapter->netdev);
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [RFC] Disable xen platform device when it is not needed., Yuji Shimada |
|---|---|
| Next by Date: | Re: [Xen-devel] HVM domain with VT-d passthrough fails to boot (was: [PATCH 2/2] ioemu: Enable guest OS to program D0-D3hot states of an assigned device), Yuji Shimada |
| Previous by Thread: | [Xen-devel] [RFC] Disable xen platform device when it is not needed., Yuji Shimada |
| Next by Thread: | [Xen-devel] Re: [PATCH ixgbe] Don't depend of skb->data for VMDq, Steven Smith |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
